lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 4 Jun 2013 12:17:45 -0400 From: Theodore Ts'o <tytso@....edu> To: Jan Kara <jack@...e.cz> Cc: linux-ext4@...r.kernel.org Subject: Re: [PATCH 06/26] jbd2: Cleanup needed free block estimates when starting a transaction On Fri, May 31, 2013 at 11:42:39AM +0200, Jan Kara wrote: > __jbd2_log_space_left() and jbd_space_needed() were kind of odd. > jbd_space_needed() accounted also credits needed for currently committing > transaction while it didn't account for credits needed for control blocks. > __jbd2_log_space_left() then accounted for control blocks as a fraction of free > space. Since results of these two functions are always only compared against > each other, this works correct but is somewhat strange. Move the estimates so > that jbd_space_needed() returns number of blocks needed for a transaction > including control blocks and __jbd2_log_space_left() returns free space in the > journal (with the committing transaction already subtracted). Rename functions > to jbd2_log_space_left() and jbd2_space_needed() while we are changing them. > > Reviewed-by: Zheng Liu <wenqing.lz@...bao.com> > Signed-off-by: Jan Kara <jack@...e.cz> Thanks, applied. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists