| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20130606145711.GC5382@thunk.org> Date: Thu, 6 Jun 2013 10:57:11 -0400 From: Theodore Ts'o <tytso@....edu> To: kbuild test robot <fengguang.wu@...el.com> Cc: Jan Kara <jack@...e.cz>, kbuild-all@...org, sfr@...b.auug.org.au, linux-ext4@...r.kernel.org Subject: Re: [ext4:dev 43/52] fs/ext4/inode.c:2211:6: warning: 'err' may be used uninitialized in this function On Wed, Jun 05, 2013 at 02:02:53PM +0800, kbuild test robot wrote: > All warnings: > > fs/ext4/inode.c: In function 'ext4_da_writepages': > >> fs/ext4/inode.c:2211:6: warning: 'err' may be used uninitialized in this function [-Wmaybe-uninitialized] > fs/ext4/inode.c:2154:6: note: 'err' was declared here This looks like a false warning. mpage_map_and_submit_extent() is only capped when mpd.m_len is non-zero. Hence we will execute the budy of the while loop in that function at least once, which means err will be initialized. I'm curious what gcc version and/or -Wall flags triggered this warning. I'm using gcc 4.7.2 from Debian and it's not complaining. I'm happy to initialize err to zero just to shut up the gcc warning, but I'm curious how often it's triggered, since this looked pretty trivial for gcc to be able to figure out on its own. Thanks, - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists