lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 12 Jun 2013 22:57:20 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	linux-ext4@...r.kernel.org, linux-rt-users@...r.kernel.org
Subject: Re: [PATCH 3/6] jbd2: fix duplicate debug label for phase 2

On Tue, Jun 11, 2013 at 06:44:27PM -0400, Paul Gortmaker wrote:
> Currently we see this output:
> 
>   $git grep phase fs/jbd2
>   fs/jbd2/commit.c:       jbd_debug(3, "JBD2: commit phase 1\n");
>   fs/jbd2/commit.c:       jbd_debug(3, "JBD2: commit phase 2\n");
>   fs/jbd2/commit.c:       jbd_debug(3, "JBD2: commit phase 2\n");
>   fs/jbd2/commit.c:       jbd_debug(3, "JBD2: commit phase 3\n");
>   fs/jbd2/commit.c:       jbd_debug(3, "JBD2: commit phase 4\n");
>   [...]
> 
> There is clearly a duplicate label for phase 2, and they are
> both active (i.e. not in #if ... #else block).  Rename them to
> be "2a" and "2b" so the debug output is unambiguous.
> 
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Applied, thanks

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists