lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAPgLHd-2_uHg9q_7nQway8uCigH=wgXxiGm9auYDNL_pByzJHA@mail.gmail.com> Date: Tue, 18 Jun 2013 11:40:34 +0800 From: Wei Yongjun <weiyj.lk@...il.com> To: tytso@....edu, liwang@...ntukylin.com, adilger.kernel@...ger.ca Cc: yongjun_wei@...ndmicro.com.cn, linux-ext4@...r.kernel.org Subject: [PATCH -next] ext4: fix missing unlock on error in ext4_punch_hole() From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn> Add the missing unlock before return from function ext4_punch_hole() in the error handling case. Introduced by commit 1cdec9ca46c2c2a7ce452659f43dac64ad5fbc85. (ext4: Avoid unnecessarily writing back dirty pages before hole punching) Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn> --- fs/ext4/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 2644679..06136b5 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -3538,7 +3538,7 @@ int ext4_punch_hole(struct file *file, loff_t offset, loff_t length) if (ext4_should_order_data(inode)) { ret = ext4_begin_ordered_punch_hole(inode, offset, length); if (ret) - return ret; + goto out_mutex; } /* Now release the pages and zero block aligned part of pages*/ -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists