lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20130622034832.GA4727@thunk.org> Date: Fri, 21 Jun 2013 23:48:32 -0400 From: Theodore Ts'o <tytso@....edu> To: Jan Kara <jack@...e.cz> Cc: Ext4 Developers List <linux-ext4@...r.kernel.org> Subject: Re: [PATCH 1/2] ext4: remove while loop in mpage_map_and_submit_extent() On Fri, Jun 21, 2013 at 06:32:36PM +0200, Jan Kara wrote: > This is not true. In case blocksize < pagesize and we were not able to > map a full page, mpage_map_and_submit_buffers() changes mpd->map to point > to the next extent inside the page that needs mapping. In that case we can > take several iterations of the loop. Maybe this fact deserves a comment > before the loop but there's a comment before the callsite of > mpage_map_and_submit_buffers() which mentions that it will get us next > extent to map and also the documentation of mpage_map_and_submit_buffers() > explicitely tells that it can update mpd->map. Ah, right. Thanks, I missed where that was happening the first time I was analyzing that function. I've dropped this patch. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists