lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 26 Jun 2013 10:41:42 -0400 From: Theodore Ts'o <tytso@....edu> To: Dave Chinner <david@...morbit.com> Cc: linux-ext4@...r.kernel.org, Zheng Liu <gnehzuil.liu@...il.com> Subject: Re: [PATCH FOR DISCUSSION] add delalloc debugging On Wed, Jun 26, 2013 at 11:18:23PM +1000, Dave Chinner wrote: > Do not use VFS level locks and list walks in filesystem code, > not even in debugging code. It's ok for you to do this in private > patches and maintain such abuses yourself, but it's not acceptible > for merging into the mainline tree... Well, that's why I wasn't proposing that the code be enabled by default, and why I described it as "a little gross". > Besides, you haven't even used the correct lock - these bdi > writeback lists are protected by the bdi writeback list lock, not > the superblock inode list lock.... Thanks for pointing that out. I'll fix that. Cheers, - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists