linux-ext4 - Re: [PATCH 1/2 V2] mke2fs: fix force option to create filesystem on mounted device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1306271103260.1781@localhost.localdomain>
Date:	Thu, 27 Jun 2013 11:05:18 +0200 (CEST)
From:	Lukáš Czerner <lczerner@...hat.com>
To:	Kazuya Mio <k-mio@...jp.nec.com>
cc:	Andreas Dilger <adilger@...ger.ca>, tytso@....edu,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 1/2 V2] mke2fs: fix force option to create filesystem on
 mounted device

On Mon, 24 Jun 2013, Kazuya Mio wrote:

> Date: Mon, 24 Jun 2013 15:28:59 +0900
> From: Kazuya Mio <k-mio@...jp.nec.com>
> To: Andreas Dilger <adilger@...ger.ca>, tytso@....edu
> Cc: linux-ext4@...r.kernel.org
> Subject: [PATCH 1/2 V2] mke2fs: fix force option to create filesystem on
>     mounted device
> 
> According to mke2fs man, we can create a filesystem on the mounted device
> when -FF option is specified.
> However, currently we have to specify -F option third to force mke2fs.

Oh, you mean we have to specify -F option three times ? It took me
some time to understand. Please rephrase the description.

Otherwise the patch looks good.

Thanks!
-Lukas

> This patch fixes the problem.
> 
> Signed-off-by: Kazuya Mio <k-mio@...jp.nec.com>
> ---
>  misc/util.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/misc/util.c b/misc/util.c
> index 6c93e1c..40c8858 100644
> --- a/misc/util.c
> +++ b/misc/util.c
> @@ -150,7 +150,7 @@ void check_mount(const char *device, int force, const char *type)
>  	}
>  	if (mount_flags & EXT2_MF_MOUNTED) {
>  		fprintf(stderr, _("%s is mounted; "), device);
> -		if (force > 2) {
> +		if (force >= 2) {
>  			fputs(_("mke2fs forced anyway.  Hope /etc/mtab is "
>  				"incorrect.\n"), stderr);
>  			return;
> @@ -162,7 +162,7 @@ void check_mount(const char *device, int force, const char *type)
>  	if (mount_flags & EXT2_MF_BUSY) {
>  		fprintf(stderr, _("%s is apparently in use by the system; "),
>  			device);
> -		if (force > 2) {
> +		if (force >= 2) {
>  			fputs(_("mke2fs forced anyway.\n"), stderr);
>  			return;
>  		}
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html