lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CA+55aFyRLc81s03ULLZ26N0qwRqxS-9+6XpyhxVH62qx2b5o2A@mail.gmail.com> Date: Tue, 2 Jul 2013 10:18:32 -0700 From: Linus Torvalds <torvalds@...ux-foundation.org> To: "Theodore Ts'o" <tytso@....edu> Cc: "linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [GIT PULL] ext4 updates for 3.11 Hmm I'm getting this compiler warning: fs/ext4/inode.c: In function ‘ext4_writepages’: fs/ext4/inode.c:2219:6: warning: ‘err’ may be used uninitialized in this function [-Wmaybe-uninitialized] and I think the compiler is right to warn. The 'err' variable is set inside a whilte() and an if() statement, and it is not at all obvious that those codepaths are always taken. Maybe that "map->m_len" is always guaranteed to be nonzero, and the "while()" statement could be a "do { } while()" one. But if so, make it so, don't write code as if it might never be executed, when the return value seems to *depend* on it being executed. Or just initialize the variable correctly. This warning may not be new to this pull, I just happened to notice it now. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists