linux-ext4 - Re: [PATCH] ext4: Silence warning in ext4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130706015832.GA32062@thunk.org>
Date:	Fri, 5 Jul 2013 21:58:32 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Lukáš Czerner <lczerner@...hat.com>
Cc:	Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: Silence warning in ext4_writepages()

On Wed, Jul 03, 2013 at 12:07:25PM +0200, Lukáš Czerner wrote:
> On Tue, 2 Jul 2013, Jan Kara wrote:
> 
> > Date: Tue,  2 Jul 2013 20:14:29 +0200
> > From: Jan Kara <jack@...e.cz>
> > To: Ted Tso <tytso@....edu>
> > Cc: linux-ext4@...r.kernel.org, Jan Kara <jack@...e.cz>
> > Subject: [PATCH] ext4: Silence warning in ext4_writepages()
> > 
> > The loop in mpage_map_and_submit_extent() is guaranteed to always run at
> > least once since the caller of mpage_map_and_submit_extent() makes sure
> > map->m_len > 0. So make that explicit using do-while instead of pure
> > while which also silences the compiler warning about uninitialized 'err'
> > variable.
> 
> Looks good.
> 
> Reviewed-by: Lukas Czerner <lczerner@...hat.com>

Applied, thanks.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html