linux-ext4 - Re: fs/ext4/inode.c::mpage_map_and_submit_extent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 7 Jul 2013 06:51:08 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
Cc:	Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org
Subject: Re: fs/ext4/inode.c::mpage_map_and_submit_extent - unused variable
 warning

On Sun, Jul 07, 2013 at 11:54:55AM +0200, Stefan Richter wrote:
> Hi,
> 
> gcc 4.6.3 says:
> fs/ext4/inode.c: In function ‘ext4_writepages’:
> fs/ext4/inode.c:2219:6: warning: ‘err’ may be used uninitialized in this function [-Wuninitialized]
> fs/ext4/inode.c:2161:6: note: ‘err’ was declared here
> 
> It would be an actual bug if mpage_map_and_submit_extent(handle, mpd, ...)
> can be called with mpd->map.m_len == 0.  Can it?

It can't and we have a patch queued up to remove the warning.

Cheers,

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html