lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20130722131406.GA2895@gmail.com> Date: Mon, 22 Jul 2013 21:14:07 +0800 From: Zheng Liu <gnehzuil.liu@...il.com> To: Jan Kara <jack@...e.cz> Cc: linux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org, Zheng Liu <wenqing.lz@...bao.com>, Al Viro <viro@...iv.linux.org.uk> Subject: Re: [PATCH] ext3: fix a bug when we try to open a file with O_TMPFILE flag Hi Jan, On Mon, Jul 22, 2013 at 03:07:37PM +0200, Jan Kara wrote: > On Sun 21-07-13 00:53:47, Zheng Liu wrote: > > From: Zheng Liu <wenqing.lz@...bao.com> > > > > When we try to open a file with O_TMPFILE flag, we will trigger a bug. > > The root cause is that in ext4_orphan_add() we check ->i_nlink == 0 and > > this check always fails because we set ->i_nlink = 1 in > > inode_init_always(). We can use the following program to trigger it: [...] > > Here we couldn't call clear_nlink() directly because in d_tmpfile() we > > will call inode_dec_link_count() to decrease ->i_nlink. So this commit > > tries to call d_tmpfile() before ext4_orphan_add() to fix this problem. > Thanks the patch looks good. I've added the patch to my tree and will > push it to Linus soon. Thanks for your review. Ted has pick it up and Linus has pulled the patch. Sorry, I forgot to remind you. http://www.gossamer-threads.com/lists/linux/kernel/1750649 - Zheng -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists