linux-ext4 - Re: [PATCH 1/1] ext4: Fix Opts: (null)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51EF980C.5010203@gmail.com>
Date:	Wed, 24 Jul 2013 09:02:04 +0000
From:	"Jóhann B. Guðmundsson" 
	<johannbg@...il.com>
To:	Eric Sandeen <sandeen@...hat.com>
CC:	Theodore Tso <tytso@....edu>,
	Andreas Dilger <adilger.kernel@...ger.ca>,
	linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
	"Jóhann B. Guðmundsson" 
	<johannbg@...oraproject.org>
Subject: Re: [PATCH 1/1] ext4: Fix Opts: (null)

On 07/24/2013 02:18 AM, Eric Sandeen wrote:
> Have you tested it?  What's the difference in output?

  
-	ext4_msg(sb, KERN_INFO, "mounted filesystem with%s. "
-		 "Opts: %s%s%s", descr, sbi->s_es->s_mount_opts,
+	ext4_msg(sb, KERN_INFO, "mounted filesystem with%s "
+		 "%s%s%s mount option(s)", descr, sbi->s_es->s_mount_opts,
  		 *sbi->s_es->s_mount_opts ? "; " : "", orig_data);


From
mounted filesystem with  Opts: (null)
re-mounted. Opts:(null)

To

mounted filesystem with (null) mount option(s)
re-mounted (null) mount option(s)

That (null) could change to no or none I suppose but it still feels a bit off thou maybe this output sample would be better?

if = (null)

mounted filesystem
re-mounted filesystem

elif

mounted filesystem with x,y.x mount option(s)
re-mounted filesystem with x,y.x mount option(s)

JBG

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html