linux-ext4 - Re: [PATCH 2/5] ext4: Fix type declaration of ext4_validate_block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130726160613.GA25936@blackbox.djwong.org>
Date:	Fri, 26 Jul 2013 09:06:13 -0700
From:	"Darrick J. Wong" <darrick.wong@...cle.com>
To:	"Theodore Ts'o" <tytso@....edu>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 2/5] ext4: Fix type declaration of
 ext4_validate_block_bitmap

On Wed, Jul 24, 2013 at 03:12:01PM +0800, Zheng Liu wrote:
> On Fri, Jul 19, 2013 at 04:55:46PM -0700, Darrick J. Wong wrote:
> > The block_group parameter to ext4_validate_block_bitmap is both used as a
> > ext4_group_t inside the function and the same type is passed in by all callers.
> > We might as well use the typedef consistently instead of open-coding the
> > 'unsigned int'.
> > 
> > Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>
> > ---
> >  fs/ext4/balloc.c |    2 +-
> >  fs/ext4/ext4.h   |    2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > 
> > diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c
> > index b430afe..735e701 100644
> > --- a/fs/ext4/balloc.c
> > +++ b/fs/ext4/balloc.c
> > @@ -352,7 +352,7 @@ static ext4_fsblk_t ext4_valid_block_bitmap(struct super_block *sb,
>                                           ^^^
> It seems that this function also needs to be fixed.

Yep.  I'll get that in the next version, thank you.

--D
> 
>                                                 - Zheng
> 
> >  
> >  void ext4_validate_block_bitmap(struct super_block *sb,
> >  			       struct ext4_group_desc *desc,
> > -			       unsigned int block_group,
> > +			       ext4_group_t block_group,
> >  			       struct buffer_head *bh)
> >  {
> >  	ext4_fsblk_t	blk;
> > diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> > index b577e45..39d24e2 100644
> > --- a/fs/ext4/ext4.h
> > +++ b/fs/ext4/ext4.h
> > @@ -1915,7 +1915,7 @@ extern ext4_group_t ext4_get_group_number(struct super_block *sb,
> >  
> >  extern void ext4_validate_block_bitmap(struct super_block *sb,
> >  				       struct ext4_group_desc *desc,
> > -				       unsigned int block_group,
> > +				       ext4_group_t block_group,
> >  				       struct buffer_head *bh);
> >  extern unsigned int ext4_block_group(struct super_block *sb,
> >  			ext4_fsblk_t blocknr);
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html