linux-ext4 - Re: [PATCH 1/2] debugfs.c: the max length of debugfs argument is too short

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130729023756.GD5827@thunk.org>
Date:	Sun, 28 Jul 2013 22:37:56 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Robert Yang <liezhi.yang@...driver.com>
Cc:	linux-ext4@...r.kernel.org, dvhart@...ux.intel.com,
	darrick.wong@...cle.com
Subject: Re: [PATCH 1/2] debugfs.c: the max length of debugfs argument is too
 short

On Fri, Jul 26, 2013 at 06:30:56PM +0800, Robert Yang wrote:
> The max length of debugfs argument is 256 which is too short, the
> arguments are two paths, the PATH_MAX is 4096 according to
> /usr/include/linux/limits.h, use 2048 (4096 / 2) is a reasonable value.

I'd just use BUFSIZ (which is 8192 on Linux systems).  That's what the
ss library uses, and if you might have two paths and PATH_MAX is 4096,
2048 could easily be too small.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html