| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 17 Aug 2013 09:45:20 -0400 From: Theodore Ts'o <tytso@....edu> To: Jan Kara <jack@...e.cz> Cc: linux-ext4@...r.kernel.org Subject: Re: [PATCH 2/2] ext4: Fix warning in ext4_da_update_reserve_space() On Fri, Aug 09, 2013 at 03:07:00PM +0200, Jan Kara wrote: > reaim workfile.dbase test easily triggers warning in > ext4_da_update_reserve_space(): > > EXT4-fs warning (device ram0): ext4_da_update_reserve_space:365: > ino 12, allocated 1 with only 0 reserved metadata blocks (releasing 1 > blocks with reserved 9 data blocks) > > The problem is that (one of) tests creates file and then randomly writes > to it with O_SYNC. That results in writing back pages of the file in > random order so we create extents for written blocks say 0, 2, 4, 6, 8 > - this last allocation also allocates new block for extents. Then we > writeout block 1 so we have extents 0-2, 4, 6, 8 and we release > indirect extent block because extents fit in the inode again. Then we > writeout block 10 and we need to allocate indirect extent block again > which triggers the warning because we don't have the reservation > anymore. > > Fix the problem by giving back freed metadata blocks resulting from > extent merging into inode's reservation pool. > > Signed-off-by: Jan Kara <jack@...e.cz> Thanks, applied. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists