linux-ext4 - Re: [PATCH] ext4: Fix oops in jbd2_journal_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130817012402.GA9349@thunk.org>
Date:	Fri, 16 Aug 2013 21:24:02 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Jan Kara <jack@...e.cz>
Cc:	linux-ext4@...r.kernel.org, majianpeng <majianpeng@...il.com>,
	Lukas Czerner <lczerner@...hat.com>, stable@...r.kernel.org
Subject: Re: [PATCH] ext4: Fix oops in jbd2_journal_file_inode()

On Wed, Aug 07, 2013 at 04:41:16PM +0200, Jan Kara wrote:
> Commit 0713ed0cde76438d05849f1537d3aab46e099475 added
> jbd2_journal_file_inode() call into ext4_block_zero_page_range().
> However that function gets called from truncate path and thus inode
> needn't have jinode attached - that happens in ext4_file_open() but the
> file needn't be ever open since mount. Calling jbd2_journal_file_inode()
> without jinode attached results in the oops.
> 
> We fix the problem by attaching jinode to inode also in ext4_truncate()
> and ext4_punch_hole() when we are going to zero out partial blocks.
> 
> CC: <stable@...r.kernel.org> (from 3.10)
> Reported-by: majianpeng <majianpeng@...il.com>
> Signed-off-by: Jan Kara <jack@...e.cz>

Thanks, applied.  I've removed the cc: stable since commit
0713ed0cde764 didn't show up until v3.11-rc1.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html