lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 28 Aug 2013 14:33:40 -0400 From: Theodore Ts'o <tytso@....edu> To: Dmitry Monakhov <dmonakhov@...nvz.org> Cc: Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org Subject: Re: [PATCH 2/5] jbd2: optimize jbd2_journal_force_commit On Tue, Apr 23, 2013 at 10:51:40AM +0200, Jan Kara wrote: > > Do you give me your ACK/Reviewed signature? > Looking at it with a fresh mind I think there's still one bug: > read_unlock(&journal->j_state_lock); > if (need_to_start) > - jbd2_log_start_commit(journal, tid); > - jbd2_log_wait_commit(journal, tid); > - return 1; > + ret = jbd2_log_start_commit(journal, tid); > + if (!ret) > + ret = jbd2_log_wait_commit(journal, tid); > jbd2_log_start_commit() will return 0 if it didn't wake jbd2 thread and 1 > if it did. In either case we should call jbd2_log_wait_commit()... > > + if (!ret && progress) > + *progress = 1; I was going through old patch series, and I came across this one. Dmitry, did you have a chance to look at Jan's comments? Thanks, - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists