linux-ext4 - Re: [PATCH 2/2] ext4: use kobj_completion in ext4_sb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52311E52.4040001@suse.com>
Date:	Wed, 11 Sep 2013 21:52:18 -0400
From:	Jeff Mahoney <jeffm@...e.com>
To:	Theodore Ts'o <tytso@....edu>
Cc:	ext4 development <linux-ext4@...r.kernel.org>,
	Greg KH <gregkh@...ux.com>
Subject: Re: [PATCH 2/2] ext4: use kobj_completion in ext4_sb_info

On 9/11/13 9:48 PM, Theodore Ts'o wrote:
> On Tue, Sep 10, 2013 at 01:44:13PM -0400, Jeff Mahoney wrote:
>> Now that we have the kobj_completion structure available, let's use it
>> in ext4.
>>
>> Note that we aggregate the del/put/wait_for_completion in one
>> kobj_completion_del_and_wait call. Since the kobject isn't used for
>> anything while the fs is shutting down and we wait until it's released
>> before continuing anyway, this is safe.
>>
>> Signed-off-by: Jeff Mahoney <jeffm@...e.com>
> 
> I don't have a huge objection to this, but given that it's not fixing
> a bug, and it's not saving _that_ many lines of code, if you want to
> run the first patch through Greg's tree (which is fine with me), I
> might wait to merge this patch until 3.13, so it's not obvious that
> it's worth dealing with the inter-tree dependency, since it
> complicates testing on my end.
> 
> Does that sound reasonable?

Works for me. The ext4 case isn't something I'm in a huge rush to get in
-- it was just the most obvious (to me) existing users of the
kobj/completion pair.

-Jeff


-- 
Jeff Mahoney
SUSE Labs


Download attachment "signature.asc" of type "application/pgp-signature" (842 bytes)