linux-ext4 - Re: [PATCH 26/31] libext2fs: openfs() musn't allow bigalloc without EXT2_FLAGS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1310071450260.1975@localhost.localdomain>
Date:	Mon, 7 Oct 2013 14:50:52 +0200 (CEST)
From:	Lukáš Czerner <lczerner@...hat.com>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
cc:	tytso@....edu, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 26/31] libext2fs: openfs() musn't allow bigalloc without
 EXT2_FLAGS_64BITS

On Mon, 30 Sep 2013, Darrick J. Wong wrote:

> Date: Mon, 30 Sep 2013 18:29:28 -0700
> From: Darrick J. Wong <darrick.wong@...cle.com>
> To: tytso@....edu, darrick.wong@...cle.com
> Cc: linux-ext4@...r.kernel.org
> Subject: [PATCH 26/31] libext2fs: openfs() musn't allow bigalloc without
>     EXT2_FLAGS_64BITS
> 
> Currently, only the 64-bit bitmap implementation supports the block<->cluster
> conversions that bigalloc requires.  Therefore, if we have a bigalloc
> filesystem, require EXT2_FLAGS_64BITS be passed in to ext2fs_open().
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>
> ---
>  lib/ext2fs/openfs.c |   12 ++++++++++++
>  1 file changed, 12 insertions(+)

Looks good.

Reviewed-by: Lukas Czerner <lczerner@...hat.com>

> 
> 
> diff --git a/lib/ext2fs/openfs.c b/lib/ext2fs/openfs.c
> index 3c0bf14..f486a35 100644
> --- a/lib/ext2fs/openfs.c
> +++ b/lib/ext2fs/openfs.c
> @@ -272,6 +272,18 @@ errcode_t ext2fs_open3(const char *name, const char *io_options,
>  		retval = EXT2_ET_CORRUPT_SUPERBLOCK;
>  		goto cleanup;
>  	}
> +
> +	/*
> +	 * bigalloc requires cluster-aware bitfield operations, which at the
> +	 * moment means we need EXT2_FLAG_64BITS.
> +	 */
> +	if (EXT2_HAS_RO_COMPAT_FEATURE(fs->super,
> +				       EXT4_FEATURE_RO_COMPAT_BIGALLOC) &&
> +	    !(flags & EXT2_FLAG_64BITS)) {
> +		retval = EXT2_ET_CANT_USE_LEGACY_BITMAPS;
> +		goto cleanup;
> +	}
> +
>  	if (!EXT2_HAS_RO_COMPAT_FEATURE(fs->super,
>  					EXT4_FEATURE_RO_COMPAT_BIGALLOC) &&
>  	    (fs->super->s_log_block_size != fs->super->s_log_cluster_size)) {
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html