| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20131007131727.GC4540@thunk.org> Date: Mon, 7 Oct 2013 09:17:27 -0400 From: Theodore Ts'o <tytso@....edu> To: "Darrick J. Wong" <darrick.wong@...cle.com> Cc: linux-ext4@...r.kernel.org Subject: Re: [PATCH 02/31] libext2fs: Only link an inode into a directory once On Mon, Sep 30, 2013 at 06:26:55PM -0700, Darrick J. Wong wrote: > The ext2fs_link helper function link_proc does not check the value of ls->done, > which means that if the function finds multiple empty spaces that will fit the > new directory entry, it will create a directory entry in each of the spaces. > Instead of doing that, check the done value and don't do anything more if we've > already added the directory entry. > > Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com> Thanks, applied. One minor nit, which I'll generally fix myself when I have the chance: I generally like to fill comments at column 70, and in general, to try to keep the summary line under 76 columns if possible, so that "git log" doesn't wrap on 80 column screens. It's not always possible to do the latter, but it's something I will try to do. Also, personally prefer to use a lowercase to start the description since these constraints generally mean the summary line can't be a complete sentence. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists