lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20131007133725.GF4540@thunk.org> Date: Mon, 7 Oct 2013 09:37:25 -0400 From: Theodore Ts'o <tytso@....edu> To: "Darrick J. Wong" <darrick.wong@...cle.com> Cc: linux-ext4@...r.kernel.org Subject: Re: [PATCH 09/31] libext2fs: Rewind extent pointer when totally deleting an extent On Mon, Sep 30, 2013 at 06:27:40PM -0700, Darrick J. Wong wrote: > During a punch operation, if we decide to delete an extent out of the extent > tree, the subsequent extents are moved on top of the current extent (that is to > say, they're memmmove'd down one slot). Therefore it is not correct to advance > to the next leaf because that means we miss half the extents in the range! > Rereading the current pointer should be fine. > > Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com> Thanks, applied. BTW, in the future, this is the sort of change where creating a regression test would be highly appreciated --- especially since you presumably had to create test cases while you were creating the patch, so it's much less effort to encapsulate it into a test case while developing the patch. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists