linux-ext4 - Re: [PATCH v1 10/22] debugfs: handle inline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131012072102.GB3191@gmail.com>
Date:	Sat, 12 Oct 2013 15:21:02 +0800
From:	Zheng Liu <gnehzuil.liu@...il.com>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	linux-ext4@...r.kernel.org, Theodore Ts'o <tytso@....edu>,
	Zheng Liu <wenqing.lz@...bao.com>
Subject: Re: [PATCH v1 10/22] debugfs: handle inline_data feature in
 dirsearch command

On Fri, Oct 11, 2013 at 05:30:36PM -0700, Darrick J. Wong wrote:
> On Fri, Aug 02, 2013 at 05:49:37PM +0800, Zheng Liu wrote:
> > From: Zheng Liu <wenqing.lz@...bao.com>
> > 
> > We don't need to support inline data in dirsearch command.
> 
> What if I want to dirsearch for a directory entry?  Shouldn't debugfs print
> more than nothing?  I don't see why I shouldn't be able to search an inline
> directory?

I have discussed this with Ted [1], and the result shows that making
dirsearch command support inline data is not very useful for libext2fs.
So this time I don't add this support.  Personally, I don't object to
support this.  But, yes, I am convinced by Ted.

1. http://www.spinics.net/lists/linux-ext4/msg38376.html

Thanks,
                                                - Zheng

> 
> --D
> > 
> > Signed-off-by: Theodore Ts'o <tytso@....edu>
> > Signed-off-by: Zheng Liu <wenqing.lz@...bao.com>
> > ---
> >  debugfs/htree.c |    4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/debugfs/htree.c b/debugfs/htree.c
> > index d94dbea..b226f1d 100644
> > --- a/debugfs/htree.c
> > +++ b/debugfs/htree.c
> > @@ -387,9 +387,13 @@ void do_dirsearch(int argc, char *argv[])
> >  	pb.search_name = argv[2];
> >  	pb.len = strlen(pb.search_name);
> >  
> > +	if (ext2fs_inode_has_inline_data(current_fs, inode))
> > +		goto out;
> > +
> >  	ext2fs_block_iterate3(current_fs, inode, BLOCK_FLAG_READ_ONLY, 0,
> >  			      search_dir_block, &pb);
> >  
> > +out:
> >  	free(pb.buf);
> >  }
> >  
> > -- 
> > 1.7.9.7
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html