lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 12 Oct 2013 01:18:25 -0700 From: "Darrick J. Wong" <darrick.wong@...cle.com> To: linux-ext4@...r.kernel.org, "Theodore Ts'o" <tytso@....edu>, Zheng Liu <wenqing.lz@...bao.com> Subject: Re: [PATCH v1 14/22] mke2fs: add inline_data support in mke2fs On Sat, Oct 12, 2013 at 04:08:46PM +0800, Zheng Liu wrote: > On Fri, Oct 11, 2013 at 05:27:18PM -0700, Darrick J. Wong wrote: > [...] > > > + */ > > > + if ((fs_param.s_feature_incompat & EXT4_FEATURE_INCOMPAT_INLINE_DATA) && > > > + !(fs_param.s_feature_compat & EXT2_FEATURE_COMPAT_EXT_ATTR)) { > > > + com_err(program_name, 0, > > > + _("Ext_attr feature not enabled, so inline_data " > > > + "feature doesn't be specified")); > > > > "The inline_data feature requires the ext_attr feature." ? > > Ah, I have noticed that now we set xattr handler by default. So, yes, > inline_data feature doesn't require the ext_attr feature. I think you /do/ still need this check, just in case someone tries to mkfs -O ^ext_attr,inline_data. Defaults can be overridden. (I was merely trying to clarify the English in the error message.) --D > > Thanks, > - Zheng -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists