linux-ext4 - Re: [RFC 10/10] debugfs: use the functions in misc/util.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131014144012.GA26576@thunk.org>
Date:	Mon, 14 Oct 2013 10:40:12 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Robert Yang <liezhi.yang@...driver.com>
Cc:	linux-ext4@...r.kernel.org, dvhart@...ux.intel.com
Subject: Re: [RFC 10/10] debugfs: use the functions in misc/util.c

On Wed, Aug 28, 2013 at 01:26:00PM +0800, Robert Yang wrote:
> Use the functions in mist/util.c to reduce the duplicated code.

This patch conflicts with an earlier patch you had sent which allowed
copy_file() to handle sparse files.

Also, could you move all of the functions which you added to
misc/util.c to a new file, named something like misc/create_inode.c,
or something like that?

That will avoid bloating the tune2fs binary, which won't need any of
these new functions.

Eventually, I plan to rename libquota to libinternal, and use it for
internal functions used by e2fsprogs, and at that point we'll move
misc/util.c, e2fsck/profile.c, and the functions for creating inodes
into this libinternal library.

But for now, if you could organize these functions into a one or more
separate .c files, and leave them in the misc directory, that would be
great.

Thanks!!

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html