lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20131017034017.GC11932@thunk.org> Date: Wed, 16 Oct 2013 23:40:17 -0400 From: Theodore Ts'o <tytso@....edu> To: Ming Lei <ming.lei@...onical.com> Cc: linux-kernel@...r.kernel.org, Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org, "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org> Subject: Re: [PATCH] ext4: fix performance regression in ext4_writepages On Wed, Oct 16, 2013 at 09:18:37AM +0800, Ming Lei wrote: > Commit 4e7ea81db5(ext4: restructure writeback path) introduces > another performance regression on random write: > > - one more page may be added to ext4 extent in mpage_prepare_extent_to_map, > and will be submitted for I/O so nr_to_write will become -1 before 'done' > is set > > - the worse thing is that dirty pages may still be retrieved from page > cache after nr_to_write becomes negative, so lots of small chunks can be > submitted to block device when page writeback is catching up with write > path, and performance is hurted. > > On one arm A15 board with sata 3.0 SSD(CPU: 1.5GHz dura core, RAM: 2GB, > SATA controller: 3.0Gbps), this patch can improve below test's result > from 157MB/sec to 174MB/sec(>10%): > > dd if=/dev/zero of=./z.img bs=8K count=512K > > The above test is actually prototype of block write in bonnie++ utility. > > This patch makes sure no more pages than nr_to_write can be added to extent > for mapping, so that nr_to_write won't become negative. > > Cc: Ted Tso <tytso@....edu> > Cc: linux-ext4@...r.kernel.org > Cc: "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org> > Acked-by: Jan Kara <jack@...e.cz> > Signed-off-by: Ming Lei <ming.lei@...onical.com> Thanks, applied. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists