lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20131108032613.GB11668@thunk.org> Date: Thu, 7 Nov 2013 22:26:13 -0500 From: Theodore Ts'o <tytso@....edu> To: Eric Sandeen <sandeen@...hat.com> Cc: ext4 development <linux-ext4@...r.kernel.org> Subject: Re: [PATCH] ext4: remove unreachable code after ext4_can_extents_be_merged() On Thu, Oct 31, 2013 at 04:18:33PM -0500, Eric Sandeen wrote: > commit > ec22ba8e ext4: disable merging of uninitialized extents > > ensured that if either extent under consideration is uninit, > we decline to merge, and ext4_can_extents_be_merged() returns false. > > So there is no need for the caller to then test whether the > extent under consideration is unitialized; if it were, we > wouldn't have gotten that far. > > The comments were also inaccurate; ext4_can_extents_be_merged() > no longer XORs the states, it fails if *either* is uninit. > > Signed-off-by: Eric Sandeen <sandeen@...hat.com> Thanks, applied. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists