linux-ext4 - Re: [PATCH 15/25] e2fsck: print cluster ranges when encountering bitmap errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131125115623.GB15056@gmail.com>
Date:	Mon, 25 Nov 2013 19:56:23 +0800
From:	Zheng Liu <gnehzuil.liu@...il.com>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	tytso@....edu, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 15/25] e2fsck: print cluster ranges when encountering
 bitmap errors

On Thu, Oct 17, 2013 at 09:50:35PM -0700, Darrick J. Wong wrote:
> If pass5 finds bitmap errors in a range of clusters, don't print each
> cluster number individually when we could print only the start and end
> cluster number.  e2fsck already does this for the non-bigalloc case.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>

Reviewed-by: Zheng Liu <wenqing.lz@...bao.com>

                                                - Zheng

> ---
>  e2fsck/pass5.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> 
> diff --git a/e2fsck/pass5.c b/e2fsck/pass5.c
> index 346c831..30dc70a 100644
> --- a/e2fsck/pass5.c
> +++ b/e2fsck/pass5.c
> @@ -528,8 +528,8 @@ redo_counts:
>  			save_problem = problem;
>  		} else {
>  			if ((problem == save_problem) &&
> -			    (pctx.blk2 == i-1))
> -				pctx.blk2++;
> +			    (pctx.blk2 == i - EXT2FS_CLUSTER_RATIO(fs)))
> +				pctx.blk2 += EXT2FS_CLUSTER_RATIO(fs);
>  			else {
>  				print_bitmap_problem(ctx, save_problem, &pctx);
>  				pctx.blk = pctx.blk2 = i;
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html