lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <alpine.LFD.2.00.1312021225080.3930@localhost.localdomain> Date: Mon, 2 Dec 2013 12:29:32 +0100 (CET) From: Lukáš Czerner <lczerner@...hat.com> To: Zheng Liu <gnehzuil.liu@...il.com> cc: linux-ext4@...r.kernel.org, Andreas Dilger <adilger.kernel@...ger.ca>, "Theodore Ts'o" <tytso@....edu>, Zheng Liu <wenqing.lz@...bao.com> Subject: Re: [PATCH] ext4: enable punch hole for bigalloc On Sat, 30 Nov 2013, Zheng Liu wrote: > Date: Sat, 30 Nov 2013 22:03:38 +0800 > From: Zheng Liu <gnehzuil.liu@...il.com> > To: linux-ext4@...r.kernel.org > Cc: Andreas Dilger <adilger.kernel@...ger.ca>, Theodore Ts'o <tytso@....edu>, > Lukas Czerner <lczerner@...hat.com>, Zheng Liu <wenqing.lz@...bao.com> > Subject: [PATCH] ext4: enable punch hole for bigalloc > > From: Zheng Liu <wenqing.lz@...bao.com> > > After applied this commit (d23142c6), ext4 has supported punch hole for > a file system with bigalloc feature. But we forgot to enable it. This > commit fixes it. Hi, I actually send out this patch as a part of the series which implemented it and it even got review for Jan Kara http://www.spinics.net/lists/linux-ext4/msg37914.html however Ted noticed that xfstest shared/298 failed, but that was not due to bug in the code,but rather the problem with the test itself, see: https://lkml.org/lkml/2013/6/18/329 So I am not sure why it was not merged a long time ago. Ted probably just overlooked my response. Ted can we have my or this patch (they are the same) merged ? Thanks! -Lukas > > Cc: Andreas Dilger <adilger.kernel@...ger.ca> > Cc: "Theodore Ts'o" <tytso@....edu> > Cc: Lukas Czerner <lczerner@...hat.com> > Signed-off-by: Zheng Liu <wenqing.lz@...bao.com> > --- > fs/ext4/inode.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c > index 0757634..2d73587 100644 > --- a/fs/ext4/inode.c > +++ b/fs/ext4/inode.c > @@ -3513,11 +3513,6 @@ int ext4_punch_hole(struct inode *inode, loff_t offset, loff_t length) > if (!S_ISREG(inode->i_mode)) > return -EOPNOTSUPP; > > - if (EXT4_SB(sb)->s_cluster_ratio > 1) { > - /* TODO: Add support for bigalloc file systems */ > - return -EOPNOTSUPP; > - } > - > trace_ext4_punch_hole(inode, offset, length); > > /* > -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists