linux-ext4 - Re: [PATCH] fs: fix iversion handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131203093944.GA4906@infradead.org>
Date:	Tue, 3 Dec 2013 01:39:44 -0800
From:	Christoph Hellwig <hch@...radead.org>
To:	Andreas Dilger <adilger@...ger.ca>
Cc:	Christoph Hellwig <hch@...radead.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>, xfs@....sgi.com,
	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] fs: fix iversion handling

On Mon, Dec 02, 2013 at 03:05:07PM -0700, Andreas Dilger wrote:
> >> 	 */
> >> -	if (newsize != oldsize && (!(mask & (ATTR_CTIME | ATTR_MTIME))))
> >> -		inode->i_ctime = inode->i_mtime = current_fs_time(inode->i_sb);
> >> +	if (newsize != oldsize) {
> >> +		inode_inc_iversion(inode);
> 
> Should this be conditional on IS_I_VERSION(inode)?

btrfs sets MS_I_VERSION unconditionally.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html