linux-ext4 - Re: [PATCH 05/10] libext2fs: add explicit casts to ext2fs.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131203201355.GC9541@birch.djwong.org>
Date:	Tue, 3 Dec 2013 12:13:55 -0800
From:	"Darrick J. Wong" <darrick.wong@...cle.com>
To:	"Theodore Ts'o" <tytso@....edu>
Cc:	Ext4 Developers List <linux-ext4@...r.kernel.org>,
	Kit Westneat <kwestneat@....com>
Subject: Re: [PATCH 05/10] libext2fs: add explicit casts to ext2fs.h

On Tue, Dec 03, 2013 at 02:52:38PM -0500, Theodore Ts'o wrote:
> On Tue, Dec 03, 2013 at 11:16:08AM -0800, Darrick J. Wong wrote:
> > 
> > The function prototypes up around line 1604 need to be updated:
> > 
> > In file included from inline.c:38:0:
> > ext2fs.h:1810:17: error: conflicting types for ‘ext2fs_group_of_blk’
> > ext2fs.h:1604:12: note: previous declaration of ‘ext2fs_group_of_blk’ was here
> > ext2fs.h:1817:17: error: conflicting types for ‘ext2fs_group_of_ino’
> > ext2fs.h:1605:12: note: previous declaration of ‘ext2fs_group_of_ino’ was here
> 
> Nice catch; I didn't get these errors on my build for some reason.

I think it's because at some point I edited one of my debug patches to #define
NO_INLINE_FUNCS unconditionally so that I'd get bonked by things like that.

--D
> 
> I've applied your fix, thanks.
> 
> 					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html