linux-ext4 - Re: [PATCH v2 2/4] ext4: Add XIP functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CEC778F7.84365%andreas.dilger@intel.com>
Date:	Fri, 6 Dec 2013 20:58:50 +0000
From:	"Dilger, Andreas" <andreas.dilger@...el.com>
To:	Dave Chinner <david@...morbit.com>,
	Ross Zwisler <ross.zwisler@...ux.intel.com>
CC:	"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	"carsteno@...ibm.com" <carsteno@...ibm.com>,
	"Wilcox, Matthew R" <matthew.r.wilcox@...el.com>
Subject: Re: [PATCH v2 2/4] ext4: Add XIP functionality

On 2013/12/05 8:13 PM, "Dave Chinner" <david@...morbit.com> wrote:

>On Thu, Dec 05, 2013 at 01:02:46PM -0700, Ross Zwisler wrote:
>> This is a port of the XIP functionality found in the current version of
>> ext2.  This patch set is intended to achieve feature parity with XIP in
>> ext2 rather than non-XIP in ext4.  In particular, it lacks support for
>> splice and AIO.  We'll be submitting patches in the future to add that
>> functionality, but we think this is a good start.
>> 
>> The motivation behind this work is that we believe that the XIP feature
>> will begin to find new uses as various persistent memory devices and
>> technologies come on to the market.  Having direct, byte-addressable
>> access to persistent memory without having an additional copy in the
>> page cache can be a win in terms of I/O latency and overall memory
>> usage.
>> 
>> This patch applies cleanly to v3.13-rc2, and was tested using brd as our
>> block driver.
>
>I think I see a significant problem here with XIP write support:
>unwritten extents.
>
>xip_file_write() has no concept of post IO completion processing -
>it assumes that all that is necessary is to memcpy() the data into
>the backing memory obtained by ->get_xip_mem(), and that's all it
>needs to do.
>
>For ext4 (and other filesystems that use unwritten extents) they
>need a callback - normally done from bio completion - to run
>transactions to convert extent status from unwritten to written, or
>run other post-IO completion operations.
>
>I don't see any hooks into ext4 to turn off preallocation (e.g.
>fallocate is explicitly hooked up for XIP) when XIP is in use, so I
>can't see how XIP can work with such filesystem requirements without
>further infrastructure being added. i.e. bypassing the need for the
>page cache does not remove the need to post-IO completion
>notification to the filesystem...

In the short term (at least until it is possible to convert the extent
after it is modified) should it be an error to try and map an unwritten
extent?  That would still allow the ext4 XIP patch to land and be safely
used for regular files while the mechanism for doing the conversion is
worked out.

>Indeed, for making filesystems like XFS be able to use XIP, we're
>going to need such facilities to be provided by the XIP
>infrastructure....
>
>Cheers,
>
>Dave.
>-- 
>Dave Chinner
>david@...morbit.com
>


Cheers, Andreas
-- 
Andreas Dilger

Lustre Software Architect
Intel High Performance Data Division


--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html