[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 12 Dec 2013 13:04:39 -0800
From: Christoph Hellwig <hch@...radead.org>
To: Andreas Gruenbacher <andreas.gruenbacher@...bit.com>
Cc: Christoph Hellwig <hch@...radead.org>, viro@...iv.linux.org.uk,
linux-fsdevel@...r.kernel.org, linux-btrfs@...r.kernel.org,
linux-ext4@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net,
linux-mtd@...ts.infradead.org, Mark Fasheh <mfasheh@...e.com>,
Joel Becker <jlbec@...lplan.org>,
reiserfs-devel@...r.kernel.org, xfs@....sgi.com,
jfs-discussion@...ts.sourceforge.net, cluster-devel@...hat.com,
linux-nfs@...r.kernel.org, Jan Kara <jack@...e.cz>
Subject: Re: [PATCH 02/18] fs: add get_acl helper
On Thu, Dec 12, 2013 at 08:06:09PM +0100, Andreas Gruenbacher wrote:
> > + /*
> > + * A filesystem can force a ACL callback by just never filling the
> > + * ACL cache. But normally you'd fill the cache either at inode
> > + * instantiation time, or on the first ->get_acl call.
> > + *
> > + * If the filesystem doesn't have a get_acl() function at all, we'll
> > + * just create the negative cache entry.
> > + */
> > + if (!inode->i_op->get_acl) {
> > + set_cached_acl(inode, type, NULL);
> > + return ERR_PTR(-EAGAIN);
>
> The function should return NULL here.
Indeed. EAGAIN is the convention check_acl() in fs/namei.c uses,
but it will return that automatically if we just return NULL here.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists