lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <52AF2AC0.2030103@ubuntu.com> Date: Mon, 16 Dec 2013 11:30:56 -0500 From: Phillip Susi <psusi@...ntu.com> To: Theodore Ts'o <tytso@....edu> CC: linux-ext4@...r.kernel.org Subject: Re: [PATCH 2/4] e2image: perform in-place move -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 12/15/2013 11:33 PM, Theodore Ts'o wrote: > On Tue, Oct 08, 2013 at 11:56:30AM -0400, Phillip Susi wrote: >> If given at least one offset and only one file, assume source and >> dest are the same, and do an in place move. >> >> Signed-off-by: Phillip Susi <psusi@...ntu.com> > > You **really** only want to allow move_mode if you are in raw > mode. In particular, the safe move isn't even implemented in the > other mods (nor does it make any sense), and if the user simply > forgot to specify -r, it would be a shame if it ended up destroying > the user's file system. :-( Good point, also only with -a. Fixed. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJSryrAAAoJEI5FoCIzSKrwOicH/25obbcwApT1fMCZx3ZESYyg q2zOgJafZCZfe4cx6Knn8TDZ+gk66229IslTMi3oXDTXkPXQXdc5oAtcuAs8iKNN /bIgT+JKrwhvUsP8rL4F4oIfq1gzx9//YgS5awgyKV7653qGSmtXUdp5TZhSD8KU f8dz66pWz/jnapv072qdqJOIXRndIGTSNWfR7M/GC0DVAKn+vRJVjXYRQ1Woov2m tkzM5glZIFW5PUVngmckkUHLwxbdVHSQPQJE+Jib44ZOLmqYtcAfxfsrUxjbc/Ur jWFUZOHBoDlNEmeHafDhudw3dC3yyutW+uTFKrg9dy85g5tobZ9NICZK4XgiJfw= =/KYA -----END PGP SIGNATURE----- -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists