linux-ext4 - current e2fsprogs maint branch test results

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131217234313.GA2183@wallace>
Date:	Tue, 17 Dec 2013 18:43:13 -0500
From:	Eric Whitney <enwlinux@...il.com>
To:	linux-ext4@...r.kernel.org
Cc:	tytso@....edu, darrick.wong@...cle.com
Subject: current e2fsprogs maint branch test results

I've built the contents of the current e2fsprogs maint branch (4727c67dc2)
and run make check on both a Pandaboard (ARM) and an x86-64 VM. In each
case I used the following arguments to configure: --disable-uuidd
--disable-libuuid --disable-libblkid.

Both the ARM and x86-64 runs produced warnings when compiling ea_refcount.c
during make check.  I posted a patch yesterday (e2fsck: fix printf
conversion specs in ea_refcount.c) that clears those up for me on both
platforms.

The ARM build and make check were otherwise clean.

The x86-64 build and make check contained one more problem - a warning while
compiling debugfs.c:
../../debugfs/debugfs.c:2462:5: warning: too many arguments for format
 [-Wformat-extra-args]

This code (commit fe56188b07) is part of that used to check superblock block
numbers specified on the command line, and the error reporting has become
a little fuzzy relative to what we had previously.

Before:

root@...ug1:~# debugfs -s 327b /dev/vdc
debugfs 1.42.8 (20-Jun-2013)
debugfs: Bad superblock number - 327b

After:

root@...ug1:~# debugfs -s 327b /dev/vdc
debugfs 1.42.8 (20-Jun-2013)
debugfs: Bad block number - 327b
debugfs: Invalid block number: 327b
debugfs: Operation not permitted 

Both strtoblk() and parseulonglong() (which it calls) output error messages
for bad/invalid block numbers, which is redundant in this case.  The last
(erroneous) error message is output by the call to com_err() which also 
causes the warning noted above.

It seems to me that the call to com_err() ought to be deleted, and maybe
the immediately preceding call to strtoblk() ought to be converted to a call
to parseulonglong() to restore the original messaging.  I'd like to post a
patch, but there are a number of other calls to strtoblk() in debugfs now
that will produce two messages on errors, and the intent isn't clear to me.
Is this just an area that needed a little more polish?

Thanks,
Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html