linux-ext4 - [PATCH] e2fsck: read only parameter incorrectly compared

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1387488703-18595-1-git-send-email-tytso@mit.edu>
Date:	Thu, 19 Dec 2013 16:31:43 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	Ext4 Developers List <linux-ext4@...r.kernel.org>
Cc:	Johan Erlandsson <johan.erlandsson@...yericsson.com>,
	"Theodore Ts'o" <tytso@....edu>
Subject: [PATCH] e2fsck: read only parameter incorrectly compared

From: Johan Erlandsson <johan.erlandsson@...yericsson.com>

Don't check for lost+found in read only mode.

[Note: this patch was originally made against 1.41.14 version of
e2fsprogs found as part of the AOSP (Android Open Source Program)
tree.  My Signed-off-by relies on the fact that the original patch
author would have had to have filed a contribution agreement with Open
Handset Alliance before this commit before this commit was allowed
into the AOSP tree. -- tytso]

Signed-off-by: "Theodore Ts'o" <tytso@....edu>
---

Note: This patch was original authored on August 2, 2012.  It would have
been nice if had been sent directly to upstream earlier, but oh, well.
(This patch was sent to me via Google's Android team.)

I will apply it against the maint branch and it will be in the 1.42.9
release.

 e2fsck/pass3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/e2fsck/pass3.c b/e2fsck/pass3.c
index d87bd79..32c05b5 100644
--- a/e2fsck/pass3.c
+++ b/e2fsck/pass3.c
@@ -112,7 +112,7 @@ void e2fsck_pass3(e2fsck_t ctx)
 	/*
 	 * Force the creation of /lost+found if not present
 	 */
-	if ((ctx->flags & E2F_OPT_READONLY) == 0)
+	if ((ctx->options & E2F_OPT_READONLY) == 0)
 		e2fsck_get_lost_and_found(ctx, 1);

 	/*
-- 
1.8.5.rc3.362.gdf10213

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html