linux-ext4 - Re: [PATCH 04/10] misc/create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1387826836.5088.65.camel@dvhart-mobl4.amr.corp.intel.com>
Date:	Mon, 23 Dec 2013 11:27:16 -0800
From:	Darren Hart <dvhart@...ux.intel.com>
To:	Robert Yang <liezhi.yang@...driver.com>
Cc:	tytso@....edu, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 04/10] misc/create_inode.c: create symlink

On Mon, 2013-12-23 at 07:09 -0500, Robert Yang wrote:
> The do_symlink_internal() is used for creating symlinks, most of the
> code are from debugfs/debugfs.c, the debugfs/debugfs.c will be modified
> to use this function.
> 
> Signed-off-by: Robert Yang <liezhi.yang@...driver.com>
> ---
>  misc/create_inode.c |   34 ++++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
> 
> diff --git a/misc/create_inode.c b/misc/create_inode.c
> index 62a40de..45c8a87 100644
> --- a/misc/create_inode.c
> +++ b/misc/create_inode.c
> @@ -81,6 +81,40 @@ errcode_t do_mknod_internal(ext2_ino_t cwd, const char *name, struct stat *st)
>  /* Make a symlink name -> target */
>  errcode_t do_symlink_internal(ext2_ino_t cwd, const char *name, char *target)
>  {
> +	char			*cp;
> +	ext2_ino_t		parent_ino;
> +	errcode_t		retval;
> +	struct ext2_inode	inode;
> +	struct stat		st;
> +
> +	cp = strrchr(name, '/');
> +	if (cp) {
> +		*cp = 0;
> +		if ((retval =  ext2fs_namei(current_fs, root, cwd, name, &parent_ino))){
> +			com_err(name, retval, 0);
> +			return retval;
> +		}
> +		name = cp+1;
> +	} else {
> +		parent_ino = cwd;
> +		name = name;

What is the intent of this assignment to self? It appears to be a
conversion artifact from the debugfs do_symlink() function, and could be
dropped.

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel


--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html