linux-ext4 - Re: [PATCH 1/2] e2fsck: verify s_desc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131223210738.GB11299@thunk.org>
Date:	Mon, 23 Dec 2013 16:07:38 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	Andreas Dilger <adilger@...ger.ca>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 1/2] e2fsck: verify s_desc_size is power-of-two value

On Tue, Dec 17, 2013 at 01:19:03AM -0700, Andreas Dilger wrote:
> Add a LOG2_CHECK mode for check_super_value() so that it is easy
> to verify values that are supposed to be power-of-two values
> (s_desc_size and s_inode_size so far).  In ext2fs_check_desc()
> also check for a power-of-two s_desc_size.
> 
> Print out s_desc_size in debugfs "stats" and dumpe2fs output, if
> it is non-zero.
> 
> It turns out that the s_desc_size validation in check_super_block()
> is not currently used by e2fsck, because the group descriptors are
> verified earlier by ext2fs_check_desc(), and even without an
> explicit check of s_desc_size the group descriptors fail to align
> correctly on disk.  It makes sense to keep the check_super_block()
> regardless, in case the code changes at some point in the future.
> 
> Signed-off-by: Andreas Dilger <adilger@...ger.ca>

Thanks, applied.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html