linux-ext4 - Re: [PATCH] debugfs: silence build warning and remove incorrect error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131224160517.GD26944@thunk.org>
Date:	Tue, 24 Dec 2013 11:05:17 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	Eric Whitney <enwlinux@...il.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] debugfs: silence build warning and remove incorrect
 error message

On Sun, Dec 22, 2013 at 09:30:35PM -0500, Eric Whitney wrote:
> Commit fe56188b07 modified the code used to check the block number
> argument to the command line -s switch, adding a call to com_err().
> This causes a compile time warning because the third argument to
> com_err() isn't a string.  Also, when the block number argument is
> bad it outputs an incorrect error message - "Operation not permitted".
> 
> Fix these minor problems by removing the call to com_err().  Other
> code provides enough error reporting information in this case.
> 
> Signed-off-by: Eric Whitney <enwlinux@...il.com>

Thanks, applied.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html