linux-ext4 - Re: [PATCH 01/10] mke2fs.c: add an option: -d root-directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131226160734.GB23928@thunk.org>
Date:	Thu, 26 Dec 2013 11:07:34 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	Darren Hart <dvhart@...ux.intel.com>
Cc:	Robert Yang <liezhi.yang@...driver.com>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 01/10] mke2fs.c: add an option: -d root-directory

On Mon, Dec 23, 2013 at 11:08:17AM -0800, Darren Hart wrote:
> On Mon, 2013-12-23 at 07:09 -0500, Robert Yang wrote:
> > This option is used for adding the files from a given directory (the
> > root-directory) to the filesystem, it is similiar to genext2fs, but
> > genext2fs doesn't fully support ext4.
> > 
> > This commit describes the skeleton of the implementation:
> 
> This approach strikes me as a bit odd. We're adding an option and empty
> functions, rather than fleshing them out at the same time. What is the
> motivation for separating this from the actual implementation? At the
> very least the -d option shouldn't be added until it is functional - at
> the end of the series...

I think this approach was used because I complained that intermediate
versions of the commits didn't compile, and this makes bisection
harder.

I'm not going to be that picky about the specific order, though, so
long as after each commit, the result compiles and passes the
regression test suite, although adding support for -d at the very end
does make sense.  Or you could only support directories and regular
files, and then add support for symlinks, special files, etc.

Cheers,

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html