linux-ext4 - Re: debugfs: restore and tweak original error messaging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131230214521.GA5693@thunk.org>
Date:	Mon, 30 Dec 2013 16:45:21 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	Eric Whitney <enwlinux@...il.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: debugfs: restore and tweak original error messaging

On Sun, Dec 29, 2013 at 10:47:54PM -0500, Eric Whitney wrote:
> In response to reviewer comments, commit fe56188b07 included changes
> that modified some of the code used to output error messages when
> checking user-supplied block numbers.  These changes converted calls
> to parse_ulonglong() to calls to strtoblk().  Because strtoblk() calls
> parse_ulonglong(), and both output error messages, two redundant and
> relatively generic messages were output on each error.
> 
> Fix this by removing the error message output from strtoblk(), and
> extending it to accept an optional error message argument that it
> supplies in lieu of a default to parse_ulonglong().  Also, revert to
> the more descriptive original error messages with mods per reviewer
> comments, and fix an error message in do_replace_node().
> 
> Signed-off-by: Eric Whitney <enwlinux@...il.com>

Applied to the maint branch, thanks!!

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html