linux-ext4 - Re: [PATCH 08/10] debugfs: remove dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52CC35FF.8000302@redhat.com>
Date:	Tue, 07 Jan 2014 11:14:39 -0600
From:	Eric Sandeen <sandeen@...hat.com>
To:	"Theodore Ts'o" <tytso@....edu>,
	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH 08/10] debugfs: remove dead code

On 1/7/14, 8:53 AM, Theodore Ts'o wrote:
> Addresses-Coverity-Id: #1138573
> 
> Signed-off-by: "Theodore Ts'o" <tytso@....edu>

Reviewed-by: Eric Sandeen <sandeen@...hat.com>

FWIW, Darrick had already sent this as part of

"[PATCH 1/2] misc: fix resource leaks in e2fsprogs"

- but I suppose small targeted patches are better.

-Eric

> ---
>  debugfs/debugfs.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/debugfs/debugfs.c b/debugfs/debugfs.c
> index 998af33..0e56ead 100644
> --- a/debugfs/debugfs.c
> +++ b/debugfs/debugfs.c
> @@ -289,8 +289,6 @@ void do_init_filesys(int argc, char **argv)
>  	if (err)
>  		return;
>  	ext2fs_blocks_count_set(&param, blocks);
> -	if (err)
> -		return;
>  	retval = ext2fs_initialize(argv[1], 0, &param,
>  				   unix_io_manager, &current_fs);
>  	if (retval) {
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html