linux-ext4 - Re: [PATCH 37/74] libext2fs: don't always read backup group descriptors on a 1k-block meta

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140111185944.GC1582@thunk.org>
Date:	Sat, 11 Jan 2014 13:59:44 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 37/74] libext2fs: don't always read backup group
 descriptors on a 1k-block meta_bg fs

On Tue, Dec 10, 2013 at 05:22:26PM -0800, Darrick J. Wong wrote:
> On a filesystem with 1K blocks and meta_bg enabled, opening a
> filesystem with automatic superblock detection tries to compensate for
> the fact that the superblock lives in block 1.  However, the method by
> which this is done is later misinterpreted to mean "read the backup
> group descriptors", which is not what we want in this case.
> 
> Therefore, in ext2fs_open3() separate the 'group zero' adjustment into
> its own variable so that we don't get fed backup group descriptors
> when we try to load meta_bg group descriptors.
> 
> Furthermore, enhance ext2fs_descriptor_block_loc2() to perform its own
> group zero correction.  The other caller of this function neglects to
> do any group-zero correction of their own, so this fixes them too.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>

Thanks, applied to the maint branch.

							- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html