linux-ext4 - Re: [PATCH 40/74] libext2fs: no need to clear BLOCK_UNINIT during ext2fs_reserve_super_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140111191826.GF1582@thunk.org>
Date:	Sat, 11 Jan 2014 14:18:26 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	Akira Fujita <a-fujita@...jp.nec.com>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 40/74] libext2fs: no need to clear BLOCK_UNINIT during
 ext2fs_reserve_super_and_bgd

On Tue, Dec 10, 2013 at 05:22:46PM -0800, Darrick J. Wong wrote:
> Since the beginning of the uninit_bg feature, the kernel[1] and
> e2fsck[2] have always been careful to detect the presence of the
> BLOCK_UNINIT flag, and compute a block bitmap with any group metadata
> blocks marked in that bitmap.  With that in mind, I think it's safe to
> say that this is a design feature of uninit_bg.
> 
> Now that we've trained libext2fs to have this same behavior whenever
> it's loading a block bitmap, we no longer need to unset BLOCK_UNINIT
> for a group that contains only its own group metadata -- kernel,
> e2fsck, and e2fsprogs will handle this correctly.
> 
> [1] kernel git 717d50e4971b81b96c0199c91cdf0039a8cb181a
>     "Ext4: Uninitialized Block Groups"
> [2] e2fsprogs git f5fa20078bfc05b554294fe9c5505375d7913e8c
>     "Add support for EXT2_FEATURE_COMPAT_LAZY_BG"
> 
> Reported-by: Akira Fujita <a-fujita@...jp.nec.com>
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>

Thanks, applied.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html