linux-ext4 - Re: [PATCH] chattr: improve the description for 'j' option in manpage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140205165528.GA8749@localhost.localdomain>
Date:	Wed, 5 Feb 2014 14:55:28 -0200
From:	Carlos Maiolino <cmaiolino@...hat.com>
To:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] chattr: improve the description for 'j' option in manpage

This looks good to me. Consider it 

Reviewed-by: Carlos Maiolino <cmaiolino@...hat.com>

On Thu, Jan 30, 2014 at 11:46:16AM +0800, Zheng Liu wrote:
> From: Zheng Liu <wenqing.lz@...bao.com>
> 
> Ext4 file system also supports to set/clear 'j' attribute, but it just
> say that this option is only useful for ext3 in manpage.  This commit
> fixes it.
> 
> Cc: Theodore Ts'o <tytso@....edu>
> Signed-off-by: Zheng Liu <wenqing.lz@...bao.com>
> ---
>  misc/chattr.1.in |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/misc/chattr.1.in b/misc/chattr.1.in
> index 932ef4b..2a3640c 100644
> --- a/misc/chattr.1.in
> +++ b/misc/chattr.1.in
> @@ -112,8 +112,8 @@ to the file.  Only the superuser or a process possessing the
>  CAP_LINUX_IMMUTABLE capability can set or clear this attribute.
>  .PP
>  A file with the `j' attribute has all of its data written to the ext3
> -journal before being written to the file itself, if the filesystem is
> -mounted with the "data=ordered" or "data=writeback" options.  When the
> +or ext4 journal before being written to the file itself, if the filesystem
> +is mounted with the "data=ordered" or "data=writeback" options.  When the
>  filesystem is mounted with the "data=journal" option all file data
>  is already journalled and this attribute has no effect.  Only
>  the superuser or a process possessing the CAP_SYS_RESOURCE
> @@ -171,7 +171,7 @@ The `c', 's',  and `u' attributes are not honored
>  by the ext2, ext3, and ext4 filesystems as implemented in the current
>  mainline Linux kernels.
>  .PP
> -The `j' option is only useful if the filesystem is mounted as ext3.
> +The `j' option is only useful if the filesystem is mounted as ext3 or ext4.
>  .PP
>  The `D' option is only useful on Linux kernel 2.5.19 and later.
>  .SH AVAILABILITY
> -- 
> 1.7.9.7
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Carlos
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html