linux-ext4 - Re: [PATCH 6/6] libext2fs: try to roll back when splitting an extent fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140206203429.GN19884@thunk.org>
Date:	Thu, 6 Feb 2014 15:34:29 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 6/6] libext2fs: try to roll back when splitting an extent
 fails

On Tue, Jan 21, 2014 at 03:49:46PM +0800, Zheng Liu wrote:
> On Mon, Jan 20, 2014 at 10:22:17PM -0800, Darrick J. Wong wrote:
> > If a client asks us to remap a block in the middle of an extent, we
> > potentially have to allocate a fair number of blocks to handle extent
> > tree splits.  A failure in either of the ext2fs_extent_insert calls
> > leaves us with an extent tree that no longer maps the logical block in
> > question and everything that came after it!  Therefore, try to roll
> > back the extent tree changes before returning an error code.
> > 
> > Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>
> 
> Reviewed-by: Zheng Liu <wenqing.lz@...bao.com>

Thanks, applied.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html