linux-ext4 - Re: [PATCH] ext4: don't leave i_crtime.tv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5301E4F3.8050104@oracle.com>
Date:	Mon, 17 Feb 2014 11:31:15 +0100
From:	Vegard Nossum <vegard.nossum@...cle.com>
To:	"Theodore Ts'o" <tytso@....edu>,
	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext4: don't leave i_crtime.tv_sec uninitialized

On 02/17/2014 01:31 AM, Theodore Ts'o wrote:
> If the i_crtime field is not present in the inode, don't leave the
> field uninitialized.
>
> Reported-by: Vegard Nossum <vegard.nossum@...cle.com>
> Signed-off-by: "Theodore Ts'o" <tytso@....edu>
> ---
>   fs/ext4/ext4.h | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index ece5556..d3a534f 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -771,6 +771,8 @@ do {									       \
>   	if (EXT4_FITS_IN_INODE(raw_inode, einode, xtime))		       \
>   		(einode)->xtime.tv_sec = 				       \
>   			(signed)le32_to_cpu((raw_inode)->xtime);	       \
> +	else								       \
> +		(einode)->xtime.tv_sec = 0;				       \
>   	if (EXT4_FITS_IN_INODE(raw_inode, einode, xtime ## _extra))	       \
>   		ext4_decode_extra_time(&(einode)->xtime,		       \
>   				       raw_inode->xtime ## _extra);	       \
>

This fixes everything for me, thanks!


Vegard
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html