linux-ext4 - Re: [PATCH] ext4: address a benign compiler warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140218014354.GE26580@thunk.org>
Date:	Mon, 17 Feb 2014 20:43:54 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	Patrick Palka <patrick@...cs.ath.cx>
Cc:	linux-kernel@...r.kernel.org, adilger.kernel@...ger.ca,
	linux-ext4@...r.kernel.org, joe@...ches.com
Subject: Re: [PATCH] ext4: address a benign compiler warning

On Wed, Feb 12, 2014 at 11:12:04PM -0500, Patrick Palka wrote:
> When !defined(CONFIG_EXT4_DEBUG), mb_debug() should be defined as a
> no_printk() statement instead of an empty statement in order to suppress
> the following compiler warning:
> 
> fs/ext4/mballoc.c: In function ‘ext4_mb_cleanup_pa’:
> fs/ext4/mballoc.c:2659:47: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
>    mb_debug(1, "mballoc: %u PAs left\n", count);
> 
> Signed-off-by: Patrick Palka <patrick@...cs.ath.cx>

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html