lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140219215805.GA1714@gmail.com> Date: Wed, 19 Feb 2014 22:58:05 +0100 From: Dongsu Park <dongsu.park@...fitbricks.com> To: Namjae Jeon <linkinjeon@...il.com> Cc: viro@...iv.linux.org.uk, david@...morbit.com, bpm@....com, tytso@....edu, adilger.kernel@...ger.ca, jack@...e.cz, mtk.manpages@...il.com, lczerner@...hat.com, linux-fsdevel@...r.kernel.org, xfs@....sgi.com, linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org, Namjae Jeon <namjae.jeon@...sung.com>, Ashish Sangwan <a.sangwan@...sung.com> Subject: Re: [PATCH v5 3/10] ext4: Add support FALLOC_FL_COLLAPSE_RANGE for fallocate Hi Namjae, see below: On 19.02.2014 01:38, Namjae Jeon wrote: > This patch implements fallocate's FALLOC_FL_COLLAPSE_RANGE for Ext4. ...<snip>... > + /* > + * Don't start shifting extents until we make sure the hole is big > + * enough to accomodate the shift. > + */ > + path = ext4_ext_find_extent(inode, start - 1, NULL, 0); > + depth = path->p_depth; > + extent = path[depth].p_ext; > + ex_start = extent->ee_block; > + ex_end = extent->ee_block + ext4_ext_get_actual_len(extent); > + ext4_ext_drop_refs(path); > + kfree(path); > + > + if ((start == ex_start && shift > ex_start) || > + (shift > start - ex_end)) { This line causes a compile error. So the fix would be like that: - (shift > start - ex_end)) { + (shift > start - ex_end)) > + return -EINVAL; > + > + /* Its safe to start updating extents */ ...<snip>... Apart from that, the whole patchset seems to work without error, both on xfs and on ext4. Of course I had to remove Lukas' patches before testing collapse-range. So it would be excellent if two patch series could get somehow merged. Tested-by: Dongsu Park <dongsu.park@...fitbricks.com> Regards, Dongsu -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists