linux-ext4 - Re: [PATCH] misc: Use unsigned long long for file block count in filefrag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <op.xbqtefu20ncgu9@vitalif.vhome>
Date:	Sun, 23 Feb 2014 20:28:53 +0400
From:	"Vitaliy Filippov" <vitalif@...rcmc.ru>
To:	"Theodore Ts'o" <tytso@....edu>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] misc: Use unsigned long long for file block count in
 filefrag

> Hi Vitaliy,
>
> Thanks for the patch!  Your patch is missing a Signed-Off-By footer.
> Also, you note that numblocks gets passed to filefrag_fibmap(), so if
> you're going to do this, and we fall back to using fibmap, you should
> probably check to see if numblocks would overflow an unsigned long,
> and if so, to give an error because fibmap ioctl only supports the use
> of a ulong.

OK, I've just resubmitted it :)

In fact, the block count was reported incorrectly for files bigger than  
0xffffffff bytes, not blocks, because filefrag does (numblocks *  
fsinfo.f_bsize >> blk_shift), and this overflows when numblocks is  
32-bit...

-- 
With best regards,
   Vitaliy Filippov
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html