lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140225201539.GZ13647@dastard> Date: Wed, 26 Feb 2014 07:15:40 +1100 From: Dave Chinner <david@...morbit.com> To: Lukas Czerner <lczerner@...hat.com> Cc: linux-ext4@...r.kernel.org, xfs@....sgi.com, linux-fsdevel@...r.kernel.org Subject: Re: [PATCH 2/6] xfstests: Add fallocate zero range operation to fsstress On Tue, Feb 25, 2014 at 08:15:24PM +0100, Lukas Czerner wrote: > Signed-off-by: Lukas Czerner <lczerner@...hat.com> commit message? > @@ -2561,6 +2567,62 @@ punch_f(int opno, long r) > } > > void > +zero_f(int opno, long r) > +{ > +#ifdef FALLOCATE > + int e; > + pathname_t f; > + int fd; > + __int64_t lr; > + off64_t off; > + off64_t len; > + struct stat64 stb; > + int v; > + char st[1024]; [snip] We now have 3 copies of this fallocate code, the only difference between the copies being the mode: > + int mode = FALLOC_FL_ZERO_RANGE; passed into the fallocate function. Please factor. > + > + init_pathname(&f); > + if (!get_fname(FT_REGFILE, r, &f, NULL, NULL, &v)) { > + if (v) > + printf("%d/%d: zero range - no filename\n", procid, opno); > + free_pathname(&f); > + return; > + } > + fd = open_path(&f, O_RDWR); > + e = fd < 0 ? errno : 0; while you are there, get rid of the ternary operations and just use if (fd < 0) e = errno; > + check_cwd(); This can go after we've checked for an error on open, which avoids needing to save the errno.... Cheers, Dave. -- Dave Chinner david@...morbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists